Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides to java/scala_sources and (scala_)junit_tests targets #13297

Open
Eric-Arellano opened this issue Oct 19, 2021 · 0 comments
Open
Labels
backend: JVM JVM backend-related issues

Comments

@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Oct 19, 2021

Doing this only involves adding OverridesField.

I only haven't done it yet because the help messages would be much more useful if we had fields like timeout and skip_google_java_format to put in the example. To do that, we should probably have those fields exist first.

@Eric-Arellano Eric-Arellano added the backend: JVM JVM backend-related issues label Oct 19, 2021
Eric-Arellano added a commit that referenced this issue Oct 20, 2021
…tobuf_sources` (#13298)

See #13270.

This does not yet add the field to `java_sources` and `junit_tests`, tracked by #13297.

I'm not sure if we should add this mechanism to `files` and `resources`? I'm having a hard time thinking of when you would want to override the metadata for a single file. But, we might want to do it for the sake of consistency?

This also does not hook up `python_requirements` and `poetry_requirements` because those use the old CAOF macro system, rather than the Target API.

[ci skip-rust]
@stuhood stuhood changed the title Add overrides to java_sources and junit_tests targets Add overrides to java/scala_sources and (scala_)junit_tests targets Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: JVM JVM backend-related issues
Projects
None yet
Development

No branches or pull requests

1 participant