[internal] add JvmToolBase for lockfile handling for JVM tools (#13777

)

Add `JvmToolBase` as base class for subsystems that handle lockfiles for JVM tools. Adds `jvm-generate-lockfiles` goal for rebuilding JVM tool lockfiles.

Port the junit test goal to use `JvmToolBase`.

src/python/pants/backend/experimental/java/register.py

@@ -19,7 +19,7 @@
 from pants.jvm import util_rules as jvm_util_rules
 from pants.jvm.dependency_inference import symbol_mapper
 from pants.jvm.goals import coursier
-from pants.jvm.resolve import coursier_fetch, coursier_setup
+from pants.jvm.resolve import coursier_fetch, coursier_setup, jvm_tool
 from pants.jvm.target_types import JvmArtifact, JvmDependencyLockfile
 
 
@@ -53,4 +53,5 @@ def rules():
         *jvm_util_rules.rules(),
         *jdk_rules.rules(),
         *target_types_rules(),
+        *jvm_tool.rules(),
     ]

src/python/pants/backend/experimental/scala/register.py

@@ -21,7 +21,7 @@
 from pants.jvm import classpath, jdk_rules
 from pants.jvm import util_rules as jvm_util_rules
 from pants.jvm.goals import coursier
-from pants.jvm.resolve import coursier_fetch, coursier_setup
+from pants.jvm.resolve import coursier_fetch, coursier_setup, jvm_tool
 from pants.jvm.target_types import JvmArtifact, JvmDependencyLockfile
 
 
@@ -55,4 +55,5 @@ def rules():
         *jdk_rules.rules(),
         *dep_inf_rules.rules(),
         *target_types_rules(),
+        *jvm_tool.rules(),
     ]

src/python/pants/backend/java/subsystems/junit.py

@@ -1,14 +1,24 @@
 # Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
 # Licensed under the Apache License, Version 2.0 (see LICENSE).
-
+from pants.jvm.resolve.jvm_tool import JvmToolBase
 from pants.option.custom_types import shell_str
-from pants.option.subsystem import Subsystem
+from pants.util.docutil import git_url
 
 
-class JUnit(Subsystem):
+class JUnit(JvmToolBase):
     options_scope = "junit"
     help = "The JUnit test framework (https://junit.org)"
 
+    default_version = "5.7.2"
+    default_artifacts = [
+        "org.junit.platform:junit-platform-console:1.7.2",
+        "org.junit.jupiter:junit-jupiter-engine:{version}",
+        "org.junit.vintage:junit-vintage-engine:{version}",
+    ]
+    default_lockfile_resource = ("pants.backend.java.test", "junit.default.lockfile.txt")
+    default_lockfile_path = "src/python/pants/backend/java/test/junit.default.lockfile.txt"
+    default_lockfile_url = git_url(default_lockfile_path)
+
     @classmethod
     def register_options(cls, register):
         super().register_options(register)

src/python/pants/backend/java/test/BUILD

@@ -1,5 +1,7 @@
 # Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
 # Licensed under the Apache License, Version 2.0 (see LICENSE).
 
-python_sources()
+python_sources(dependencies=[":lockfiles"])
 python_tests(name="tests", timeout=240)
+
+resources(name="lockfiles", sources=["*.lockfile.txt"])