-
-
Notifications
You must be signed in to change notification settings - Fork 647
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perform tilde expansion on path_metadata_request
Within the pants repo itself, the inputs to `path_metadata_request` are commonly used on the components of the `PATH` variable. These would presumable be valid paths, but people have all sorts of crusty oddities in their shell configs. In particular if one does something reasonable looking like `export PATH="~/.local/bin:$PATH"` (note the quotes) than the path component will be a literal `~/.local/bin` and not expanded to the home directory. This is because tilde expansion happened *before* <https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06> the quote removal. Since bash and friends are cool fine with literal tildes in `PATH`, everyone would reasonable expect pants to be too.
- Loading branch information
1 parent
390416b
commit 327d988
Showing
4 changed files
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters