Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add init-pants action input.experimental-remote-cache-via-gha #30

Merged
merged 2 commits into from
May 18, 2024

Conversation

cognifloyd
Copy link
Member

This makes the documented workflow step available via a simple boolean input flag:
https://www.pantsbuild.org/2.20/docs/using-pants/remote-caching-and-execution/remote-caching#workflow

Also, I noticed the README was out of date, so I updated it.

@cognifloyd cognifloyd added the enhancement New feature or request label May 17, 2024
@cognifloyd cognifloyd self-assigned this May 17, 2024
@cognifloyd cognifloyd requested a review from a team May 17, 2024 20:27
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

Worth a quick blog post?

@cognifloyd cognifloyd merged commit d767b35 into main May 18, 2024
@cognifloyd
Copy link
Member Author

A blog post would be great. I don't have enough bandwidth to work on that though. This is a drive-by PR trying to simplify experimenting with this in the StackStorm repo.

Hopefully someone who is more versed in the new feature can write a blog post.

@Eric-Arellano Eric-Arellano deleted the gha-remote-caching branch May 18, 2024 14:38
@huonw
Copy link
Contributor

huonw commented May 19, 2024

Nice one! Thanks @cognifloyd . Looking at this, I wonder if the recipe (and this action) could also set PANTS_REMOTE_PROVIDER=experimental-github-actions-cache to make this truly "one button"... but maybe we should only do that once it's non-experimental.

Worth a quick blog post?

I'm a bit nervous about a blog post due to pantsbuild/pants#20133 / actions/cache#1280 : we'll be publicising something we know doesn't work. But, maybe trying to get publicity about that would help GH prioritise work on it higher.

@cognifloyd
Copy link
Member Author

cognifloyd commented May 19, 2024

Nice one! Thanks @cognifloyd . Looking at this, I wonder if the recipe (and this action) could also set PANTS_REMOTE_PROVIDER=experimental-github-actions-cache to make this truly "one button"... but maybe we should only do that once it's non-experimental.

I thought about trying to set the other options via env vars, but I'm not sure if all options can be set by env var, or just those that opt in like the password for twine. So, I opted to just follow the documentation and make sure people are thinking about the downsides before fully enabling this.

I like the idea of making it "one button" once it comes out of experimental.

@cognifloyd
Copy link
Member Author

cognifloyd commented May 19, 2024

I'm a bit nervous about a blog post due to pantsbuild/pants#20133 / actions/cache#1280 : we'll be publicising something we know doesn't work. But, maybe trying to get publicity about that would help provide GH prioritise work on it higher.

Yes. In my experimentation, I hit the rate limit really quickly even though I'm not using pants for very much yet. If we publish a blog post, it should include a section detailing the short comings and a plea to GitHub to improve the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants