Don't download get-pants.sh into repo root.
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloading into the repo root will cause subsequent `pants tailor --check` calls to fail (unless there happens to be a `shell_sources` target in the build root). Download into `/tmp` instead.
kaos
approved these changes
Mar 1, 2023
jsirois
approved these changes
Mar 1, 2023
| if [[ -f ./get-pants.sh ]]; then | ||
| ./get-pants.sh | ||
| else | ||
| curl --proto '=https' --tlsv1.2 -fsSLo /tmp/get-pants.sh \ |
There was a problem hiding this comment.
I guess /tmp/get-pants.sh is probably fine, but using mktemp or GITHUB_ACTION_PATH to get a truly unique path seems like better form. You never know what another action might do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading into the repo root will cause subsequent
pants tailor --checkcalls to fail (unless there happens to be ashell_sourcestarget in the build root). Download into/tmpinstead.