-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the init-pants action to work with scie-pants. #16
Conversation
Note that to keep it simple, this new version doesn't support the old If we want to avoid people haphazardly upgrading the action without first having switched to scie-pants, we can rename it, or give it a new version scheme. |
Am manually testing this, but reviews welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used scie-pants yet. These changes look sane, I just have a few questions.
Does adding a description to inputs work now? There are some places that take a description, and others that don't. I believe I ran into issues with reusable workflows not allowing it, so I'm guessing that actions metadata allows it. Have you tested using this anywhere? Maybe in a PR in the example-python repo?
I'm testing this out, but I believe descriptions work. |
Shouldn't the interpreter version be tied to the Pants version, rather than to |
Since scie-pants installs pantsbuild.pants in a venv it has to know the appropriate version of the hermetic PBS to use to do that install. When Pants switches distribution model to scie / PEX, if it chooses the (loose) scie route, Pants can completely control the Python it uses without letting scie-pants know. At that point this action will need to be updated to deal with that new state of the world. |
- Use an in-repo get-pants.sh if available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the interpreter step back. I see one typo, and then LGTM
No description provided.