replacing kv globals with caching module part 2 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwayne
approved these changes
Oct 12, 2023
darwayne
reviewed
Oct 12, 2023
Comment on lines
-284
to
-287
| kv_table().put_item(Item={"key": key, _DICT_COL: data}) | ||
|
|
||
| if epoch_seconds: | ||
| set_key_expiration(key, epoch_seconds) |
There was a problem hiding this comment.
[out of scope] rant this should really be one request instead of 2
There was a problem hiding this comment.
Yes true. We changed it to 1 in the caching module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This change was originally made in #884
But that was reverted here #889
This is adding it back now that we are ready to
Changes
Testing