Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using caching module in detections instead of globals #888

Merged
merged 7 commits into from
Oct 13, 2023
Merged

using caching module in detections instead of globals #888

merged 7 commits into from
Oct 13, 2023

Conversation

maxrichie5
Copy link
Contributor

@maxrichie5 maxrichie5 commented Sep 27, 2023 •
edited
Loading

Background

We want to use the caching module going forward. The globals are just for backcompat

Changes

  • Replace global helper kv store imports with caching module from PDH
  • Some dev dependency updates
  • format changes

Testing

  • Existing CI

@maxrichie5 maxrichie5 marked this pull request as ready for review September 28, 2023 15:22
@maxrichie5 maxrichie5 requested a review from a team September 28, 2023 15:22
dekatzenel
dekatzenel previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@dekatzenel dekatzenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra formatting changes feel superfluous, but substantive changes look good

@maxrichie5
Copy link
Contributor Author

Extra formatting changes feel superfluous, but substantive changes look good

Its what make fmt did so I left it

@maxrichie5 maxrichie5 marked this pull request as draft September 28, 2023 16:20
@maxrichie5 maxrichie5 marked this pull request as ready for review October 12, 2023 22:01
@maxrichie5 maxrichie5 merged commit 47cd166 into master Oct 13, 2023
1 check passed
@maxrichie5 maxrichie5 deleted the maxrichmond/kv/update-detections-to-use-caching branch October 13, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesheffield sesheffield sesheffield approved these changes

@dekatzenel dekatzenel dekatzenel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxrichie5 @dekatzenel @sesheffield