Introduce data model unit tests #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le4ker
reviewed
Dec 9, 2024
| class TestAWSCloudTrailDataModel(unittest.TestCase): | ||
| data_model = log_type_to_data_model.get("AWS.CloudTrail") | ||
|
|
||
| def test_get_actor_user(self): |
There was a problem hiding this comment.
Technically this unit test tests the UDM, not the get_actor_user
le4ker
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There is currently no good way to test complex data model functions. This PR introduces a
data_models_test.pyto add this functionality, similar toglobal_helpers_test.pyChanges
data_models_test.pywith initial test case for AWSget_actor_userfunctionTesting