Remove API flags for CI Checks #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantjoy
approved these changes
Mar 21, 2024
egibs
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Remove API flags for CI Checks (#1159) * Remove API flags for CI Checks * Remove validate Workflow; move validation to upload Workflow * chore: remove outdated license text (#1160) * Bump PDH version and Pipfile.lock (#1161) * custom enrichment LUT for TrailDiscover (#1162) * Add detection for multiple emails for gitlab password reset (#1157) * Add detection for multiple emails for gitlab password reset * Update gitlab_audit_password_reset_multiple_emails.py * Update rules/gitlab_rules/gitlab_audit_password_reset_multiple_emails.yml * Update rules/gitlab_rules/gitlab_audit_password_reset_multiple_emails.yml * Update rules/gitlab_rules/gitlab_production_password_reset_multiple_emails.yml * Update rules/gitlab_rules/gitlab_production_password_reset_multiple_emails.yml --------- Co-authored-by: Ariel Ropek <79653153+arielkr256@users.noreply.github.com> * Update PAT to 0.44.0 (#1163) * add prettier formatter (#1153) --------- Co-authored-by: Lucy Suddenly <43256356+LucySuddenly@users.noreply.github.com> Co-authored-by: Grant Joy <9968195+grantjoy@users.noreply.github.com> Co-authored-by: Ariel Ropek <79653153+arielkr256@users.noreply.github.com> Co-authored-by: Oleh Melenevskyi <767472+melenevskyi@users.noreply.github.com> Co-authored-by: Panos Sakkos <panos.sakkos@panther.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We originally added
--api-hostand--api-tokento support SDYAML Rule validation and testing since PAT does not support this locally right now.This PR removes that change; this also means that fork PRs will be able to run the Checks without failing.
Changes
--api-hostand--api-tokenfrom the Test and Validate WorkflowsTesting