Tweak existing exfiltration rules; add additional rules #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fabc8d to
0c6073b
Compare
arielkr256
reviewed
Dec 13, 2023
rules/aws_cloudtrail_rules/aws_ami_modified_for_public_access.yml
Outdated
Show resolved
Hide resolved
arielkr256
reviewed
Dec 13, 2023
arielkr256
reviewed
Dec 13, 2023
| event.deep_get("requestParameters", "attributeName") == "restore", | ||
| ] | ||
| ): | ||
| shared_account_ids = event.deep_get("requestParameters", "valuesToAdd", default=[]) |
There was a problem hiding this comment.
Can this be compared to userIdentity.accountId and only alert if the valuesToAdd account ID is different?
There was a problem hiding this comment.
I don't know if a snapshot can be shared with the account it's created in. We can certainly add the logic to check for it, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR adds additional exfiltration rules for RDS and tweaks existing rules. Some of the existing rules were only focusing on
groupshare events when resource sharing can also be done on an individual user/account basis.I also sorted the strings in
packs/aws.yaml.Changes
aws_rds_manual_snapshot_created.py/.ymlaws_rds_snapshot_shared.py/.ymlaws_ami_modified_for_public_access.py/.ymlaws_snapshot_made_public.pyTesting
make fmt; make lint; make test