Chore: Improve logging

imagecast/core.py

@@ -2,13 +2,17 @@
 # (c) 2020-2021 Andreas Motl <andreas@hiveeyes.org>
 # License: GNU Affero General Public License, Version 3
 import io
+import logging
 import tempfile
 
 import requests
 from PIL import Image
 from requests_cache import CachedSession
 
 
+logger = logging.getLogger(__name__)
+
+
 class ImageEngine:
 
     http = None
@@ -98,6 +102,9 @@ def to_buffer(self, format, dpi):
 
 def process(options):
     ie = ImageEngine(cache_ttl=options.cache_ttl)
+
+    logger.info(f"Acquiring image from {options.uri}")
+
     ie.acquire(options.uri, options.element)
     ie.read()
 

pyproject.toml

@@ -2,6 +2,7 @@
 minversion = "2.0"
 addopts = "-rsfEX -p pytester --strict-markers --verbosity=3"
 log_level = "DEBUG"
+log_cli_level = "DEBUG"
 testpaths = ["test"]
 xfail_strict = true
 markers = [

test/test_api.py

@@ -26,7 +26,7 @@ def test_api_index():
     assert re.match(r".*<title>imagecast [\d.]+</title>.*", response.text, re.DOTALL)
 
 
-def test_api_unsplash_converge():
+def test_api_unsplash_converge(caplog):
     """
     Verify image management works.
     """
@@ -37,11 +37,16 @@ def test_api_unsplash_converge():
         "width": "640",
     }
     response = client.get("/", params=query_params)
+
+    # Verify log output.
+    assert "Acquiring image from https://unsplash.com/photos/WvdKljW55rM/download?force=true" in caplog.messages
+
+    # Verify content output.
     assert response.status_code == 200
     assert response.content.startswith(b"\xff\xd8\xff\xe0\x00\x10JFIF")
 
 
-def test_api_html_acquire():
+def test_api_html_acquire(caplog):
     """
     Verify HTML DOM element acquisition works.
     """
@@ -50,5 +55,10 @@ def test_api_html_acquire():
         "element": "#logo",
     }
     response = client.get("/", params=query_params)
+
+    # Verify log output.
+    assert "Acquiring image from https://www.iana.org/help/example-domains" in caplog.messages
+
+    # Verify content output.
     assert response.status_code == 200
     assert response.content.startswith(b"\x89PNG\r\n\x1a")

test/test_cli.py

@@ -36,7 +36,7 @@ def test_cli_unsplash_converge(tmp_path, caplog):
     imagecast.cli.run()
 
     # Verify log output.
-    assert "Starting new HTTPS connection (1): unsplash.com:443" in caplog.messages
+    assert "Acquiring image from https://unsplash.com/photos/WvdKljW55rM/download?force=true" in caplog.messages
 
     # Verify content output.
     payload = output_file.read_bytes()
@@ -52,7 +52,7 @@ def test_cli_html_acquire(tmp_path, caplog):
     imagecast.cli.run()
 
     # Verify log output.
-    assert "Starting new HTTPS connection (1): www.iana.org:443" in caplog.messages
+    assert "Acquiring image from https://www.iana.org/help/example-domains" in caplog.messages
 
     # Verify content output.
     payload = output_file.read_bytes()