Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to update the pangeo.pydata.org deployment #122

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

mrocklin
Copy link
Member

No description provided.

@mrocklin
Copy link
Member Author

cc @rabernat

@rabernat
Copy link
Member

Thanks Matt. It is great to have this dumped out of your brain and into a public place!

Eventually we will want to incorporate something like this into the sphinx site. But for now I am happy to have a page of standalone instructions.

gce/update.md Outdated
```bash
docker push dsakdev/pangeo-worker:TAG
docker push dsakdev/pangeo-notebook:TAG
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like it is possible to update the docker images without ever syncing up the pangeo repo. My worry is that, if multiple people start updating the deployment this way, we will break something and not be able to roll back because we don't have the configuration under version control.

A better scenario would be that the docker files and example notebooks are updated via PR, and the rest of the build / deploy process occurs automatically via some sort of CI magic. I recognize that this may be difficult to set up and therefore not practical right now, but I just wanted to raise the possibility.

If we don't go that route, maybe we can update these instructions to remind whoever is doing this to also push the changes to github.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this would be a good way to manage things. I'm happy to help advise others if they take this on.

@mrocklin mrocklin force-pushed the update-instructions branch from 628c2de to 444f6ba Compare February 21, 2018 15:14
@mrocklin mrocklin force-pushed the update-instructions branch from 444f6ba to 9f4fd9c Compare February 22, 2018 13:28
@mrocklin mrocklin merged commit 3c8e3e8 into pangeo-data:master Feb 22, 2018
@mrocklin mrocklin deleted the update-instructions branch February 22, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants