Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Edited doc string of pandas/core/frame.duplicated(). Redefined take... #9203

Conversation

robertdavidwest
Copy link
Contributor

..._last variable in doc string. Original definition only made sense for drop_duplicates().

…ake_last variable in doc string. Original definition only made sense for drop_duplicates().
@@ -2726,7 +2726,8 @@ def duplicated(self, subset=None, take_last=False):
Only consider certain columns for identifying duplicates, by
default use all of the columns
take_last : boolean, default False
Take the last observed row in a row. Defaults to the first row
For a set of distinct duplicate rows, flag all but the last row as duplicated.
Default is for all but the first row to be flagged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small detail: I think your new line is one space off in indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Amended.

On 6 January 2015 at 16:53, Joris Van den Bossche notifications@github.com
wrote:

In pandas/core/frame.py
#9203 (diff):

@@ -2726,7 +2726,8 @@ def duplicated(self, subset=None, take_last=False):
Only consider certain columns for identifying duplicates, by
default use all of the columns
take_last : boolean, default False

  •        Take the last observed row in a row. Defaults to the first row
    
  •         For a set of distinct duplicate rows, flag all but the last row as duplicated.
    
  •         Default is for all but the first row to be flagged
    

Very small detail: I think your new line is one space off in indentation


Reply to this email directly or view it on GitHub
https://github.com/pydata/pandas/pull/9203/files#r22555271.

@jorisvandenbossche jorisvandenbossche added this to the 0.16.0 milestone Jan 6, 2015
@shoyer
Copy link
Member

shoyer commented Jan 7, 2015

xref: #6511, #8505

looks good to me

@robertdavidwest could you please squash these commits together?

@jorisvandenbossche
Copy link
Member

Follow-up: #9206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants