-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API(str dtype): Raise on StringDtype for unary op + #60710
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
pandas/core/arrays/string_arrow.py
Outdated
@@ -4,6 +4,7 @@ | |||
import re | |||
from typing import ( | |||
TYPE_CHECKING, | |||
Never, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably too new? (some CI is failing on this import)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still gives some typing error ...
pandas/core/arrays/string_arrow.py:484: error: Return type "None" of "__pos__" incompatible with
return type "ArrowStringArray" in supertype "ArrowExtensionArray" [override]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems others are typed as def __pos__(self) -> Self:
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Python strings, NumPy string arrays, object dtype, and StringDtype backed by Python all raise for this op.