Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Format
decimal.Decimal
as full precision strings in.to_json(...)
#60698ENH: Format
decimal.Decimal
as full precision strings in.to_json(...)
#60698Changes from all commits
a2175c0
1c6781d
a17820d
d60f71f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be ideal if our functions retuned
const char*
so we didn't have to cast like this. A lot of this code is old and has changed hands many times, so not surprised there are some code smells...but if you are looking to continuing contributions on this, that cleanup would be greatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the test cases cover this code? If not, can you add a NaN case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should cover it:
https://github.com/Tolker-KU/pandas/blob/d60f71fe3d20bef8eca0861e742a392dc2c35d4a/pandas/tests/io/json/test_pandas.py#L2027-L2039
https://github.com/Tolker-KU/pandas/blob/d60f71fe3d20bef8eca0861e742a392dc2c35d4a/pandas/conftest.py#L476-L481
https://github.com/Tolker-KU/pandas/blob/d60f71fe3d20bef8eca0861e742a392dc2c35d4a/pandas/_testing/__init__.py#L165