Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate units 'w', 'd', 'MS', 'US', 'NS' for Timedelta in favor of 'W', 'D', 'ms', 'us', 'ns' #59051

Merged
merged 6 commits into from
Jun 21, 2024
Merged

DEPR: deprecate units 'w', 'd', 'MS', 'US', 'NS' for Timedelta in favor of 'W', 'D', 'ms', 'us', 'ns' #59051

merged 6 commits into from
Jun 21, 2024

Conversation

natmokval
Copy link
Contributor

xref #58998

@natmokval natmokval added Deprecate Functionality to remove in pandas Timedelta Timedelta data type labels Jun 19, 2024
@natmokval natmokval marked this pull request as ready for review June 19, 2024 18:21
@natmokval natmokval requested a review from MarcoGorelli as a code owner June 19, 2024 18:21
MarcoGorelli
MarcoGorelli reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @natmokval!

Just one question - do we still need c_DEPR_ABBREVS, or can c_DEPR_UNITS be used in its place?

@natmokval
Copy link
Contributor Author

Nice one, thanks @natmokval!

Just one question - do we still need c_DEPR_ABBREVS, or can c_DEPR_UNITS be used in its place?

Thanks @MarcoGorelli for reviewing this PR. I think we need c_DEPR_ABBREVS, because so far it's allowed to use lowercase strings w, d, b and c for offsets/period.

After deprecation lowercase strings w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes (PR #58998 is ready for review) we can use c_DEPR_UNITS instead c_DEPR_ABBREVS.

MarcoGorelli
MarcoGorelli approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining! Cool, I think this is ready then

Approving, leaving open a little in case anyone has objections

@mroeschke mroeschke added this to the 3.0 milestone Jun 21, 2024
@mroeschke mroeschke merged commit 73ea3c1 into pandas-dev:main Jun 21, 2024
45 of 47 checks passed
@mroeschke
Copy link
Member

Thanks @natmokval

@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Open
23 tasks
This was referenced Jun 24, 2024
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Timedelta Timedelta data type
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@natmokval @mroeschke @MarcoGorelli