-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: lowercase freqs 'ye', 'qe', etc. raise a ValueError #56910
DEPR: lowercase freqs 'ye', 'qe', etc. raise a ValueError #56910
Conversation
@MarcoGorelli, could you please take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in time - well done for spotting this and fixing it so close to the release!
Looking forwards to enforcing these deprecations so that all this complexity can be reduced
Nice one @natmokval !
…raise a ValueError
Thank you for reviewing this PR! |
@MarcoGorelli is this scheduled for removal in 4.0? you might need to manually move the deprecation bullet from the 4.0 tracker issue to the 3.0 tracker issue if it isn't. |
thanks, will do |
…#56910) * correct dict _dont_uppercase, def to_offset, fix test * fix tests, add tests
xref #56346, #56847, #9586
Using lowercase frequencies such as ‘y’, ‘ye’, ‘q’, ‘qe’, etc. raise a
ValueError
on main, though it worked before. Using those was never documented, but if people are use these lowercase frequencies, we should keep them work.For example:
The definition of
to_offset
is corrected, so now we can see theFutureWarning
.