Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: replace deprecated freqs in user_guide Period #55831

Merged

Conversation

natmokval
Copy link
Contributor

@natmokval natmokval commented Nov 4, 2023

xref #54061

replaced deprecated frequencies in user_guide Period with new frequencies.

@natmokval natmokval marked this pull request as ready for review November 5, 2023 10:07
@natmokval natmokval added the Docs label Nov 5, 2023
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you grep that they aren't anywhere else?

@phofl phofl added this to the 2.2 milestone Nov 5, 2023
@phofl phofl merged commit 6493d2a into pandas-dev:main Nov 5, 2023
@phofl
Copy link
Member

phofl commented Nov 5, 2023

thx @natmokval

@natmokval
Copy link
Contributor Author

natmokval commented Nov 9, 2023

Can you grep that they aren't anywhere else?

yes, I used grep to check if there are anywhere else frequencies which are deprecated.
I found a couple of places where comments contain deprecated frequencies. For example in pandas/_libs/tslibs/period.pyx we have deprecated 'T': # ('T', 5) but may be passed in as a string like '5T'

I am not sure, should I change 'T' to "min' in the comment?

Also we have in asv_bench/benchmarks/ some tests with deprecated frequencies "S" and "H". I think it's better to replace them with valid frequencies, are you agree?
Could you please explain why when I run tests in asv_bench/benchmarks/ with deprecated frequencies they don't fail.

@natmokval
Copy link
Contributor Author

thanks for reviewing this PR @phofl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants