-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs #54061
Merged
MarcoGorelli
merged 47 commits into
pandas-dev:main
from
natmokval:DEPR-codes-T-L-from-_attrname_to_abbrevs-_abbrev_to_attrnames
Aug 29, 2023
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
6e3e96e
DEPR: deprecate codes T and L in to_abbrevs/_abbrev_to_attrnames
natmokval fe88663
replace T/L with min/ms in _prefix, period_code_map, _attrname_to_abb…
natmokval 1e79480
correct def get_freq for tseries, fix tests
natmokval f7fd2a1
replace T, L in _offset_to_period_map, is_subperiod, is_superperiod, …
natmokval 98e8a39
correct def to_timedelta, def _round_temporally and fix tests
natmokval 93bbd08
correct def resolution_string, get_reso_from_freqstr and fix tests
natmokval b0dfd2f
Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…
natmokval 51c62a1
fix tests
natmokval 898f811
correct def _maybe_coerce_freq , is_subperiod, is_superperiod, and _o…
natmokval 1d30c07
fix a test for plotting
natmokval 37de346
Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…
natmokval 7171237
fix tests
natmokval 29dcd8d
fix failures in asv benchmarks
natmokval 317718a
correct docstrings
natmokval 99a0cf9
deprecate abbrevs U, N add dict depr_abbrevs and fix tests
natmokval a13a041
correct get_freq and fix tests
natmokval a949282
Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…
natmokval 7bd6188
correct is_superperiod, is_subperiod, _maybe_coerce_freq and fix tests
natmokval 77949c4
correct __eq__ for PeriodDtype
natmokval a24c0ec
update docstrings
natmokval 733d68b
correct whatsnew and user_guide
natmokval beeac14
correct tables of Offset/Period aliases in user_guide
natmokval a3e3522
correct warning message, add the warning to some tests
natmokval 65ddf90
resolve conflicts in tests
natmokval c61b0fb
add the futurewarning to def asfreq, fix tests
natmokval c2f45ba
add the futurewarning to to_offset, correct warning message and add t…
natmokval 73405bf
add the warning to parse_timedelta_unit, remove t, l, u, n from timed…
natmokval b2ab238
correct docstrings, update user_guide for timeseries and add tests
natmokval 4775471
update whatsnew/v2.1.0.rst
natmokval c3ed691
remove warning from to_timedelta, correct tests
natmokval 155b0a7
Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…
natmokval 31d292c
deprecate 'S' in favour of 's', fix tests
natmokval d5dabd0
fix tests
natmokval 9cf0565
correct parse_iso_format_string, fix tests
natmokval 609646e
correct docs
natmokval cc04261
correct docs
natmokval 93533d9
correct docstrings in PeriodProperties
natmokval 9ba1734
Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…
natmokval b79e9b6
correct docs, tests, and add lines to whatsnew/v2.2.0.rst
natmokval 3408d0b
resolve conflict
natmokval 12888f8
correct examples in docs
natmokval cdd5f6b
resolve conflict
natmokval c7b8b24
resolve conflict
natmokval 5bb2ca8
correct v2.2.0.rst and test_subset
natmokval c54e431
resolve conflict in v2.2.0.rst
natmokval 0966d2f
resolve conflict
natmokval 271bd6b
resolve conflict v2.2.0.rst
natmokval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need changing in this PR (can be done as a follow-up, there's plenty of time until pandas 2.2), but if we're doing these renamings, then 'H' should probably be renamed too (and CBH, and BH)
I'd stop there - then there a simple rule: anything sub-daily is lowercase, anything daily or higher is upper-case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comments. I agree, it would be better to rename 'H', 'CBH', and 'BH' too, I'll do it in a separate PR. I like the idea to keep anything sub-daily lowercase, and daily or higher upper-case.