DEPR: int slicing always positional #53338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you remember why this was reverted before? |
There was a deprecation #45324 that was basically the opposite of this (make slice-with-integer-index label-based) but i messed up the deprecation and didn't warn in enough cases (discussed #49612), so actually enforcing it would have broken a bunch more stuff. Also you pointed out (#49612 (comment)) a different inconsistency, and I guess in the Dec dev call we decided to punt on this. |
|
+1 for still moving forward with this deprecation |
|
@phofl @MarcoGorelli OK here? |
MarcoGorelli
approved these changes
Aug 4, 2023
|
Looks good just needs a rebase |
mroeschke
approved these changes
Aug 4, 2023
|
Thanks @jbrockmendel |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
* DEPR: int slicing always positional * update doc * okwarning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.We've gone back and forth on this a couple times (#45324, #49869 would have done this as a breaking change in 2.0).