Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replace test for nil gh32075 #51954

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Add replace test for nil gh32075 #51954

merged 1 commit into from
Mar 14, 2023

Conversation

liang3zy22
Copy link
Contributor

@liang3zy22 liang3zy22 commented Mar 14, 2023 •
edited
Loading

mroeschke
mroeschke reviewed Mar 14, 2023
View reviewed changes
pandas/tests/series/methods/test_replace.py Outdated
@@ -318,6 +318,13 @@ def test_replace_with_dictlike_and_string_dtype(self, nullable_string_dtype):
result = ser.replace({"one": "1", "two": "2"})
tm.assert_series_equal(expected, result)

def test_replace_with_nil_na(self):
# GH 32075
ser = pd.DataFrame({"a": ["nil", pd.NA]})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to pandas/tests/frame/methods/test_replace.py?

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Mar 14, 2023
@liang3zy22 liang3zy22 force-pushed the gh32075 branch 2 times, most recently from 4bcaf1c to 57c0b4b Compare March 14, 2023 04:00
@liang3zy22
Add replace test for nil gh32075
c21251c 
Signed-off-by: Liang Yan <ckgppl_yan@sina.cn>
@mroeschke mroeschke added this to the 2.1 milestone Mar 14, 2023
@mroeschke mroeschke merged commit 5053b56 into pandas-dev:main Mar 14, 2023
@mroeschke
Copy link
Member

Thanks @liang3zy22

@liang3zy22 liang3zy22 deleted the gh32075 branch March 14, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Series.replace fails to replace value
2 participants
@liang3zy22 @mroeschke