Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: CoW not tracking references when indexing midx with slice #51944

Merged
merged 3 commits into from
Mar 14, 2023
Merged

BUG: CoW not tracking references when indexing midx with slice #51944

merged 3 commits into from
Mar 14, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 13, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added this to the 2.0 milestone Mar 13, 2023
@phofl phofl mentioned this pull request Mar 13, 2023
Merged
5 tasks
@jorisvandenbossche
Copy link
Member

I think #51895 will (as a side affect) also fix this. But of course should merge at least the test anyway.

@phofl
Copy link
Member Author

phofl commented Mar 13, 2023

I guess we should merge this anyway since we'll backport CoW fixes?

@jorisvandenbossche
Copy link
Member

Given that the other PR is fixing an annoying bug for geopandas, I was kind of planning to backport that as well (but yeah, the order of which gets merged first doesn't matter, fine to already merge and backport this)

@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 13, 2023
Merged
5 tasks
@phofl phofl force-pushed the cow_indexing_midx_slice branch from 8335eb7 to 6f58ad7 Compare March 14, 2023 11:16
@phofl phofl merged commit eaacf83 into pandas-dev:main Mar 14, 2023
@phofl
Copy link
Member Author

phofl commented Mar 14, 2023

Lets get this into the rc to be save

@phofl phofl deleted the cow_indexing_midx_slice branch March 14, 2023 13:15
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 14, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 14, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#51944: BUG: CoW not tracking references when i…
5e2163e 
…ndexing midx with slice
phofl added a commit that referenced this pull request Mar 14, 2023
@meeseeksmachine @phofl
Backport PR #51944 on branch 2.0.x (BUG: CoW not tracking references …
4ec8ed9 
…when indexing midx with slice) (#51963)

Backport PR #51944: BUG: CoW not tracking references when indexing midx with slice

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 15, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
Copy / view semantics
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jorisvandenbossche