adding test to check if rows are skipped when skip_blank_lines is set… #50843
Conversation
|
CI is currently failing, we have to merge main after this is fixed |
|
@phofl Could you please merge this if there's no problem in the code? |
| parser = all_parsers | ||
| csv_f = StringIO( | ||
| """A, B, C, D | ||
| FOO, 1, 2, 3 |
There was a problem hiding this comment.
Can you move these lines to the beginning of each line?
…3_test_skip_blank_rows_read_csv
| """A, B, C, D | ||
| FOO, 1, 2, 3 | ||
| FOO, 4, 5, 6 | ||
| , , , |
There was a problem hiding this comment.
Sorry should have been clearer. I meant moving it completely to the left, """ allows this. Please also remove the whitespaces in the blank line completely
…3_test_skip_blank_rows_read_csv
|
Thanks for the comments and approval @phofl! |
|
Pre-commit is failing, could you check? Otherwise lgtm |
|
Not sure why 'Ubuntu / Data Manager (pull_request)' fails. Under details, I see 'The runner has received a shutdown signal...' in GHA. GH 45651". Anything I can do about it? |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
… to true in read_csv
xref #22693
test added with xfail decorator
@noatamir @phofl