Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Avoid re-computing mask in nanmedian #50838

Merged
merged 3 commits into from
Jan 19, 2023
Merged

PERF: Avoid re-computing mask in nanmedian #50838

merged 3 commits into from
Jan 19, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 18, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added this to the 2.0 milestone Jan 19, 2023
@mroeschke mroeschke added Performance Memory or execution speed performance Reduction Operations sum, mean, min, max, etc. labels Jan 19, 2023
@mroeschke mroeschke merged commit 4d0cc6f into pandas-dev:main Jan 19, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the mask_median branch January 19, 2023 20:21
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
@phofl @pooja-subramaniam
PERF: Avoid re-computing mask in nanmedian (pandas-dev#50838)
3f5870b 
* PERF: Avoid re-computing mask in nanmedian

* Add gh ref

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Performance Memory or execution speed performance Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke