Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22693 test skip blank rows read csv #50798

Closed
wants to merge 0 commits into from
Closed

22693 test skip blank rows read csv #50798

wants to merge 0 commits into from

Conversation

pooja-subramaniam
Copy link
Contributor

phofl
phofl reviewed Jan 17, 2023
View reviewed changes
pandas/tests/series/methods/test_replace.py Outdated
@@ -675,3 +675,18 @@ def test_replace_value_none_dtype_numeric(self, val):
result = ser.replace(val, None)
expected = pd.Series([1, None], dtype=object)
tm.assert_series_equal(result, expected)

def test_replace_change_dtype_series(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the wrong test? Did you use the correct branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I created a new branch for the task but it's using the last commit as the new commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I didn't update my main before creating the branch. It still shouldn't have used the last commit. Not sure how that happened!

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jan 17, 2023
@pooja-subramaniam pooja-subramaniam force-pushed the 22693_test_skip_blank_rows_read_csv branch from c79e790 to 9097263 Compare January 18, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_fwf: skip_blank_lines does nothing
3 participants
@pooja-subramaniam @phofl @mroeschke