Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REV: revert deprecation of Series.__getitem__ slicing with IntegerIndex #50283

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

jbrockmendel
Copy link
Member

@phofl phofl added this to the 1.5.3 milestone Dec 15, 2022
@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves Deprecate Functionality to remove in pandas labels Dec 15, 2022
@phofl phofl merged commit 1613f26 into pandas-dev:main Dec 17, 2022
@phofl
Copy link
Member

phofl commented Dec 17, 2022

thx @jbrockmendel

@lumberbot-app
Copy link

lumberbot-app bot commented Dec 17, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1613f26ff0ec75e30828996fd9ec3f9dd5119ca6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50283: REV: revert deprecation of Series.__getitem__ slicing with IntegerIndex'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50283-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50283 on branch 1.5.x (REV: revert deprecation of Series.getitem slicing with IntegerIndex)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl
Copy link
Member

phofl commented Jan 12, 2023

was this backported? Otherwise we should do this manually before 1.5.3

phofl pushed a commit to phofl/pandas that referenced this pull request Jan 12, 2023
phofl added a commit that referenced this pull request Jan 14, 2023
…tem__ slicing with IntegerIndex) (#50694)

* REV: revert deprecation of Series.__getitem__ slicing with IntegerIndex (#50283)

(cherry picked from commit 1613f26)

* Avoid unrelated changes

* Fix

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: is ser[:2] with Int64Index positional or label-based
2 participants