Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: add test for nested OrderedDict in constructor #50060

Merged
merged 5 commits into from
Dec 6, 2022
Merged

TST: add test for nested OrderedDict in constructor #50060

merged 5 commits into from
Dec 6, 2022

Conversation

codamuse
Copy link
Contributor

@codamuse codamuse commented Dec 4, 2022 •
edited by mroeschke
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

closes #18166

@codamuse codamuse changed the title add test for nested OrderedDict to make sure sort is maintained TST: add test for nested OrderedDict in constructor Dec 4, 2022
@codamuse codamuse mentioned this pull request Dec 4, 2022
Open
17 tasks
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Dec 5, 2022
@mroeschke mroeschke added this to the 2.0 milestone Dec 5, 2022
mroeschke
mroeschke approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to bring this PR out of draft mode we can merge

@codamuse codamuse marked this pull request as ready for review December 6, 2022 12:37
@codamuse
Copy link
Contributor Author

codamuse commented Dec 6, 2022

out of draft mode but CI is failing though looks completely unrelated :/

@mroeschke mroeschke merged commit 2d185e1 into pandas-dev:main Dec 6, 2022
@mroeschke
Copy link
Member

Thanks @codamuse

@codamuse codamuse deleted the test_nested_ordered_dicts branch December 6, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

df autosorts rows on construction with OrderedDict of OrderedDicts
2 participants
@codamuse @mroeschke