test: Add test for loc assignment changes datetime dtype #50037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alonme
commented
Dec 3, 2022
•
- closes BUG: Assignment to a .loc view of a naive datetime column changes its dtype to object #49837
- All code checks passed.
MarcoGorelli
approved these changes
Dec 3, 2022
phofl
reviewed
Dec 3, 2022
pandas/tests/indexing/test_loc.py
Outdated
| expected = df.copy(deep=True) | ||
|
|
||
| update_df = df[df["update"]] | ||
| df.loc[df["update"], ["date"]] = update_df["date"] |
There was a problem hiding this comment.
Can you test for df.loc[df["update"], ["date"]] and df.loc[df["update"], "date"]? This takes significantly different code paths.
There was a problem hiding this comment.
yup, actually the bug didn't occur in the second one.
will add.
BTW - is this the right place for the test?
There was a problem hiding this comment.
good point, better place is probably frame/indexing/test_indexing
788cd14 to
ba9b41d
Compare
|
@phofl ping |
phofl
reviewed
Dec 3, 2022
| @@ -1454,6 +1455,32 @@ def test_loc_bool_multiindex(self, dtype, indexer): | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| @pytest.mark.parametrize("utc", [False, True]) | |||
| @pytest.mark.parametrize("column_label_array", [False, True]) | |||
There was a problem hiding this comment.
You can do @pytest.mark.parametrize("indexer", ["date", ["date]]), then you don't need if on your test
phofl
approved these changes
Dec 5, 2022
|
thx @alonme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.