DEPR: enforce not-automatically aligning in DataFrame comparisons #49946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+310
to
+313
| box = box_with_array | ||
|
|
||
| ser = Series([Timestamp("2000-01-29 01:59:00"), Timestamp("2000-01-30"), NaT]) | ||
| ser = tm.box_expected(ser, box_with_array) | ||
| ser = tm.box_expected(ser, box) |
There was a problem hiding this comment.
just for my understanding, is this purely cosmetic? (no objections anyway)
There was a problem hiding this comment.
Yes, it’s a pattern we use elsewhere
MarcoGorelli
requested changes
Nov 29, 2022
There was a problem hiding this comment.
Ah wait, the related ASV checks are failing
2022-11-29T00:54:09.9434614Z [ 1.81%] ··· ...thSeriesAxis.time_frame_op_with_series_axis1 6/12 failed
2022-11-29T00:54:09.9435374Z [ 1.81%] ··· ========== ==========
2022-11-29T00:54:09.9435738Z opname
2022-11-29T00:54:09.9436168Z ---------- ----------
2022-11-29T00:54:09.9436526Z eq failed
2022-11-29T00:54:09.9437238Z ne failed
2022-11-29T00:54:09.9437518Z lt failed
2022-11-29T00:54:09.9437736Z le failed
2022-11-29T00:54:09.9437960Z ge failed
2022-11-29T00:54:09.9438183Z gt failed
2022-11-29T00:54:09.9438611Z add 12.0±0ms
2022-11-29T00:54:09.9438899Z sub 11.8±0ms
2022-11-29T00:54:09.9439204Z truediv 11.8±0ms
2022-11-29T00:54:09.9439479Z floordiv 42.0±0ms
2022-11-29T00:54:09.9439765Z mul 11.6±0ms
2022-11-29T00:54:09.9440049Z pow 31.0±0ms
2022-11-29T00:54:09.9440264Z ========== ==========
Good to have fixed the flakiness, I'd got so used to seeing that check fail I was going to just restart it, but this time it's not a false positive
1 task
mroeschke
approved these changes
Dec 1, 2022
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.