Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Index.__and__, __or__, __xor__ #49503

Merged
merged 2 commits into from
Nov 7, 2022
Merged

DEPR: Index.__and__, __or__, __xor__ #49503

merged 2 commits into from
Nov 7, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Nov 3, 2022
topper-123
topper-123 reviewed Nov 3, 2022
View reviewed changes
pandas/tests/series/test_logical_ops.py Outdated Show resolved Hide resolved
pandas/tests/series/test_logical_ops.py Outdated Show resolved Hide resolved
@topper-123 topper-123 added the Index Related to the Index class or subclasses label Nov 3, 2022
@topper-123
Copy link
Contributor

LGTM.

xref #37374

@topper-123
Copy link
Contributor

I'd be ok merging this, but am a bit new at reviewing PRs. Maybe if no one comments in the newx few hours, I'll merge it?

@mroeschke mroeschke added this to the 2.0 milestone Nov 7, 2022
@mroeschke mroeschke merged commit af4a11e into pandas-dev:main Nov 7, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel (and happy for you to merge these straightforward PRs as well in the future @topper-123)

@jbrockmendel jbrockmendel deleted the depr-setops branch November 7, 2022 19:10
@jbrockmendel jbrockmendel mentioned this pull request Nov 7, 2022
Closed
phofl pushed a commit to phofl/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @phofl
DEPR: Index.__and__, __or__, __xor__ (pandas-dev#49503)
b657437 
* DEPR: Index.__and__, __or__, __xor__

* construct expected explicitly
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @noatamir
DEPR: Index.__and__, __or__, __xor__ (pandas-dev#49503)
cd3676d 
* DEPR: Index.__and__, __or__, __xor__

* construct expected explicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @topper-123 @mroeschke