Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE enable pylint: comparison-of-constants #49502

Merged
merged 1 commit into from
Nov 3, 2022
Merged

STYLE enable pylint: comparison-of-constants #49502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/tests/io/parser/test_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ def test_dialect_conflict_except_delimiter(all_parsers, custom_dialect, arg, val

# arg=None tests when we pass in the dialect without any other arguments.
if arg is not None:
if "value" == "dialect": # No conflict --> no warning.
if value == "dialect": # No conflict --> no warning.
kwds[arg] = dialect_kwargs[arg]
elif "value" == "default": # Default --> no warning.
elif value == "default": # Default --> no warning.
Comment on lines -100 to +102
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiice

looks like these test cases were always getting skipped previously, so good thing pylint has unearthed this issue - and thanks for fixing it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I like fixing pylint warnings. Cats are cute by the way :)

from pandas.io.parsers.base_parser import parser_defaults

kwds[arg] = parser_defaults[arg]
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ disable = [

# pylint type "R": refactor, for bad code smell
"chained-comparison",
"comparison-of-constants",
"comparison-with-itself",
"consider-merging-isinstance",
"consider-using-min-builtin",
Expand Down