Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Remove truediv from eval #49267

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Oct 23, 2022

@phofl phofl added the Deprecate Functionality to remove in pandas label Oct 23, 2022
@phofl phofl added this to the 2.0 milestone Oct 23, 2022
@@ -1105,39 +1105,11 @@ def test_single_variable(self):
df2 = self.eval("df", local_dict={"df": df})
tm.assert_frame_equal(df, df2)

def test_truediv(self):
def test_truediv_removed(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we're OK just removing this test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@jbrockmendel jbrockmendel merged commit 886f841 into pandas-dev:main Oct 24, 2022
@jbrockmendel
Copy link
Member

thanks @phofl

@phofl phofl deleted the remove_truediv branch October 24, 2022 21:37
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* DEP: Remove truediv from eval

* Remove test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants