Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert FutureWarning check #48468

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Revert FutureWarning check #48468

merged 1 commit into from
Sep 8, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 8, 2022 •
edited
Loading

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

#48398

This was referenced Sep 8, 2022
Merged
Merged
mroeschke
mroeschke approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge and backport as necessary.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas labels Sep 8, 2022
@phofl phofl added this to the 1.6 milestone Sep 8, 2022
@phofl phofl merged commit 5bcf4d5 into pandas-dev:main Sep 8, 2022
@phofl phofl deleted the revert-future_warning branch September 8, 2022 18:55
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
Revert FutureWarning check (pandas-dev#48468)
b20f495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke