Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: fix type of level in DataFrame.groupby #47560

Merged
merged 1 commit into from
Jul 1, 2022
Merged

TYP: fix type of level in DataFrame.groupby #47560

merged 1 commit into from
Jul 1, 2022

Conversation

twoertwein
Copy link
Member

fixes #47548

@@ -109,7 +109,7 @@

Axis = Union[str, int]
IndexLabel = Union[Hashable, Sequence[Hashable]]
Level = Union[Hashable, int]
Level = Hashable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change: int is Hashable. No need to explicitly list int.

@mroeschke mroeschke added this to the 1.5 milestone Jul 1, 2022
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Jul 1, 2022
@mroeschke mroeschke merged commit f6ba50a into pandas-dev:main Jul 1, 2022
@mroeschke
Copy link
Member

Thanks @twoertwein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TYP: level parameter of DataFrame.groupby has incorrect type hint (should accept sequence)
2 participants