-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: consistency of input args for boundaries - Interval #46522
ENH: consistency of input args for boundaries - Interval #46522
Conversation
Hi There is still issues inside code PR submit. Will tag reviewers once I finish. Thank |
can you rebase this (as the pickle fix was merged) |
can you rebase once more |
the doc build is failing, which is working on master; its possible its superfluous, so if it builds locally can you rebase again. |
@jreback The pipeline in greeen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @weikhor this is great!
…das-dev#46522)" This reverts commit 7e23a37.
…48116) * Revert "Cln tests interval wrt inclusive (#47775)" This reverts commit 2d6e0b2. * Revert "CLN: Rename private variables to inclusive (#47655)" This reverts commit 102b3ca. * Revert "TYP: Improve typing interval inclusive (#47646)" This reverts commit 5506476. * Revert "DEPR: Deprecate set_closed and add set_incluive (#47636)" This reverts commit bd4ff39. * Revert "DEPR: Remove deprecation from private class IntervalTree (#47637)" This reverts commit f6658ef. * Revert "Revert inclusive default change of IntervalDtype (#47367)" This reverts commit d9dd128. * Revert "ENH: consistency of input args for boundaries - Interval (#46522)" This reverts commit 7e23a37. * Revert "ENH: consistency of input args for boundaries - pd.interval_range (#46355)" This reverts commit 073b353. * Fix ArrowIntervalType manually * Remove unused import * Fix doctest and leftover usage * Fix remaining tests * Fix wording in doctoring Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
…andas-dev#48116) * Revert "Cln tests interval wrt inclusive (pandas-dev#47775)" This reverts commit 2d6e0b2. * Revert "CLN: Rename private variables to inclusive (pandas-dev#47655)" This reverts commit 102b3ca. * Revert "TYP: Improve typing interval inclusive (pandas-dev#47646)" This reverts commit 5506476. * Revert "DEPR: Deprecate set_closed and add set_incluive (pandas-dev#47636)" This reverts commit bd4ff39. * Revert "DEPR: Remove deprecation from private class IntervalTree (pandas-dev#47637)" This reverts commit f6658ef. * Revert "Revert inclusive default change of IntervalDtype (pandas-dev#47367)" This reverts commit d9dd128. * Revert "ENH: consistency of input args for boundaries - Interval (pandas-dev#46522)" This reverts commit 7e23a37. * Revert "ENH: consistency of input args for boundaries - pd.interval_range (pandas-dev#46355)" This reverts commit 073b353. * Fix ArrowIntervalType manually * Remove unused import * Fix doctest and leftover usage * Fix remaining tests * Fix wording in doctoring Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.