Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: improving example #45262

Closed
wants to merge 1 commit into from
Closed

DOC: improving example #45262

wants to merge 1 commit into from

Conversation

realead
Copy link
Contributor

@realead realead commented Jan 8, 2022

This is a minimal fix: the example with strange output is replaced (even if the underlying problem is not fixed/should be fixed)

Now the output in the current version is:

Index([None, NaT, True], dtype='object')

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually need to fix this for 1.4 (the actual issue which i think is just the repr), e.g. these are already separate things IIUC

@realead
Copy link
Contributor Author

realead commented Jan 9, 2022

@jreback I've proposed a fix for repr-issue in #45283. Not sure it is good to make such a change shortly before release (and thus this much more minimal PR) also probably some discussion needed what is actually the desired and consistent behavior (probably not only series are affected).

@jreback
Copy link
Contributor

jreback commented Jan 10, 2022

closing in favor of #45283

@jreback jreback closed this Jan 10, 2022
@jreback
Copy link
Contributor

jreback commented Jan 10, 2022

@jreback I've proposed a fix for repr-issue in #45283. Not sure it is good to make such a change shortly before release (and thus this much more minimal PR) also probably some discussion needed what is actually the desired and consistent behavior (probably not only series are affected).

yeah i think your change is fine

@jreback jreback added this to the 1.4 milestone Jan 10, 2022
@jreback jreback added the Output-Formatting __repr__ of pandas objects, to_string label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: value counts with mixed NaNs is oddly rendering
2 participants