PERF: avoid calling .values to know the result dtype in eval() #44791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Dec 6, 2021
| (i.e. calling ``mgr.as_array()`` or ``df.values``). | ||
| """ | ||
| if len(self.arrays) == 0: | ||
| return np.dtype(float) |
There was a problem hiding this comment.
can this be explicitly np.float64? i never know how this will behave on windows or 32bit builds
jbrockmendel
reviewed
Dec 7, 2021
| @@ -1549,6 +1549,22 @@ def as_array( | |||
|
|
|||
| return arr.transpose() | |||
|
|
|||
| def as_array_dtype(self): | |||
There was a problem hiding this comment.
could be shared in the base class?
11 tasks
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
@jorisvandenbossche can you merge master and update |
|
@jorisvandenbossche can you address comments and rebase |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
prob a reasonable change but closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
pd.eval(..)expression parser calls.valuesseveral times just to know the dtype of that array. When you actually need to construct this array (which can be costly), we can know this dtype without actually constructing it.TODO: I need to update the
as_array_dtypemethod to ensure it always returns anp.dtype(now it can also return an extension dtype)