ENH: Add indexing syntax to GroupBy.nth() #44688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 3, 2021
pandas/core/groupby/groupby.py
Outdated
| @@ -902,6 +905,15 @@ def __getattr__(self, attr: str): | |||
| f"'{type(self).__name__}' object has no attribute '{attr}'" | |||
| ) | |||
|
|
|||
| def __getattribute__(self, attr): | |||
There was a problem hiding this comment.
can you type args & outputs
There was a problem hiding this comment.
Typed the arg, but the output has no type
|
Hello @johnzangwill! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-12-04 16:01:30 UTC |
jreback
approved these changes
Dec 4, 2021
|
thanks @johnzangwill very nice |
|
Hi. Is this already implemented into pandas? I have a use case with groupby slice which is similar to this. Thank you! |
@emilmirzayev This has been merged to master for release in 1.4, which was scheduled for December 31 2021. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add index notation to nth for lists of integers and slices