Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: add arg validation for caption #43368

Merged
merged 3 commits into from
Sep 5, 2021

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Sep 2, 2021

this is needed since DataFrame.to_latex validates the caption arg.

(Personally not a fan of this type of explicit validation)

@attack68 attack68 marked this pull request as draft September 3, 2021 09:56
@jreback jreback added the Styler conditional formatting using DataFrame.style label Sep 4, 2021
@jreback jreback added this to the 1.4 milestone Sep 4, 2021
@jreback
Copy link
Contributor

jreback commented Sep 4, 2021

looks fine. i think ok to validate this (though the fact that we are accepting a tuple here is odd)

@attack68 attack68 marked this pull request as ready for review September 4, 2021 16:59
@attack68
Copy link
Contributor Author

attack68 commented Sep 4, 2021

looks fine. i think ok to validate this (though the fact that we are accepting a tuple here is odd)

latex captions have a short version and long version. written up in docs.

@jreback jreback merged commit 5c81ac4 into pandas-dev:master Sep 5, 2021
@attack68 attack68 deleted the validate_caption_latex branch September 5, 2021 10:13
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants