Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: pd.to_datetime with format doesn't work with pd.NA #42982

Merged
merged 11 commits into from
Sep 25, 2021

Conversation

debnathshoham
Copy link
Member

@debnathshoham debnathshoham commented Aug 11, 2021

@debnathshoham debnathshoham marked this pull request as draft August 11, 2021 10:39
@debnathshoham debnathshoham marked this pull request as ready for review August 11, 2021 16:25
@jreback jreback added Bug Datetime Datetime data dtype labels Aug 11, 2021
@jreback jreback added this to the 1.4 milestone Aug 11, 2021
@jreback jreback added the NA - MaskedArrays Related to pd.NA and nullable extension arrays label Aug 11, 2021
@debnathshoham debnathshoham requested a review from jreback August 12, 2021 18:10
@debnathshoham debnathshoham requested a review from jreback August 20, 2021 17:56
@debnathshoham
Copy link
Member Author

Hi @jreback - reverted to cython solution. Let me know if this looks good.

@debnathshoham
Copy link
Member Author

Hi @jreback - do you mind taking a look, if this is fine?

@jreback jreback merged commit 63e11e4 into pandas-dev:master Sep 25, 2021
@jreback
Copy link
Contributor

jreback commented Sep 25, 2021

thanks @debnathshoham

@debnathshoham debnathshoham deleted the gh42957 branch September 25, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pd.to_datetime with format doesn't work with pd.NA
4 participants