Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: move mypy config to pyproject.toml #42620

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

fangchenli
Copy link
Member

xref #40656

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli for the PR. can you limit this one to just the move (to reflect the PR title). Can you open another PR for the configuration changes.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jul 20, 2021
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli lgtm pending green

@simonjayhawkins simonjayhawkins added this to the 1.4 milestone Jul 20, 2021
@simonjayhawkins simonjayhawkins merged commit 06b9e49 into pandas-dev:master Jul 20, 2021
@fangchenli fangchenli deleted the move-mypy-pyproject branch July 20, 2021 19:34
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants