-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Added autofilter parameter to Excel output for both xlsxwriter and openpyxl engines #42560
Conversation
…nd openpyxl engines.
Hi @jreback , I've seen you have followed the freeze_pane discussion for the Excel output some years ago. Could you provide some feedback on this PR? |
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
It would be nice to have this PR merged, it's a fairly simple addition that adds a useful feature to the excel exporter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is only a feature of openpyxl, let's just do this via the engine_kwargs option. a test with docs would be sufficient. -1 on adding additional kwargs to the already long list.
Well, this PR adds a backend for both openpyxl and xlsxwriter. It's not limited to openpyxl only, and could potentially be extended...
Consider also the simplicity of looking up the documentation with |
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
I think this PR is fine the way it is. Don't agree with the previous review at all. |
@rhshadrach thoughts here |
I find this reasoning compelling. But it is also compelling for the numerous other features of excel, all with slightly different APIs that might or might not be implemented in different engines. Going down this road seems to me like a maintenance nightmare. Instead, I find your reasoning above to make a compelling case to remove freeze_panes. It is easy for the user to add an autofilter today:
This is why I think we should implement #43088 - make all protected attributes prefixed with |
agree with @rhshadrach here, let' privatize things more. closing this in light. |
I wouldn't call those examples "easy". |
I just know that an easier API for excel output formatting would make life easier to lots of pandas users. |
Can you expand on this? What do you find difficult? |
I understand you are not happy with having too many parameters in the I would even go as far as suggesting that the autofilter should be on by default when producing excel outputs. |
Added autofilter parameter to Excel output for both xlsxwriter and openpyxl engines