-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Deprecate arguments #41485 #41657
Conversation
Hello @Anupam-USP! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-27 12:58:55 UTC |
@Anupam-USP pls rebase & fix this up; ping when ready for a look. |
Yes I am woking on it, but haven't got any conclusive solutions. Can you please help me? |
@jreback I added the milestone since I think we want to get all these deprecations in at the same time? |
@simonjayhawkins i understand but this one is not ready |
@MarcoGorelli can you help push this over the line. |
Is there anything I can do to resolve the issue? |
what is the issue? do the ci logs not help? |
I am new to the ci logs and not able to find the solution of the them. Can you help me? |
Hey @Anupam-USP - no worries, I've added a commit this time fixing it up due to time constraints, next time I'll help out |
Okay @MarcoGorelli ! Though I wasn't fully able to resolve this issue but this was my very first PR. Thank you |
@Anupam-USP FYI: next time create a feature branch for the changes. https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#creating-a-branch |
Thanks @Anupam-USP for having started this one - if you look at what's been changed and try resample.interpolate then I think we can get that one in too |
Hi @MarcoGorelli @simonjayhawkins, |
I can try it, if it is available @simonjayhawkins @MarcoGorelli |
I think that's a good suggestion, thanks @lithomas1 ! Any others you think of, can you add them to #41657? |
Co-authored-by: Marco Gorelli <marcogorelli@protonmail.com> Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
Co-authored-by: Marco Gorelli <marcogorelli@protonmail.com> Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
inplace
#41485