-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate passing args as positional in dropna #41504
Merged
jreback
merged 8 commits into
pandas-dev:master
from
MarcoGorelli:deprecate-nonkeyword-args-dropna
May 26, 2021
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2660810
deprecate passing args as positional in dropna
MarcoGorelli d4ad702
Merge remote-tracking branch 'upstream/master' into deprecate-nonkeyw…
MarcoGorelli ad2b891
Merge remote-tracking branch 'upstream/master' into deprecate-nonkeyw…
MarcoGorelli d75abb1
fixup tests
MarcoGorelli 6cd5d52
Merge branch 'master' into deprecate-nonkeyword-args-dropna
jreback 26e651c
Merge branch 'master' into deprecate-nonkeyword-args-dropna
jreback 857c350
Merge branch 'master' into deprecate-nonkeyword-args-dropna
simonjayhawkins 87c8e74
Merge branch 'master' into deprecate-nonkeyword-args-dropna
jreback File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -231,3 +231,13 @@ def test_dropna_with_duplicate_columns(self): | |
|
||
result = df.dropna(subset=["A", "C"], how="all") | ||
tm.assert_frame_equal(result, expected) | ||
|
||
def test_dropna_pos_args_deprecation(self): | ||
# https://github.com/pandas-dev/pandas/issues/41485 | ||
df = DataFrame({"a": [1, 2, 3]}) | ||
msg = ( | ||
r"Starting with Pandas version 2\.0 all arguments of dropna except for the " | ||
r"argument 'self' will be keyword-only" | ||
) | ||
with tm.assert_produces_warning(FutureWarning, match=msg): | ||
df.dropna(1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar as in other PRs, can you still assert the result? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could probably share this test using frame_or_series fixture?