Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArrayManager] TST: enable JSON tests (except for table schema) #41075

Merged

Conversation

jorisvandenbossche
Copy link
Member

xref #39146

This already enables most of the JSON tests (it are only the table schema tests that are segfaulting). Those are mostly working because the JSON writer falls back to using df.values. This only gives some errors with datetime formatting, for which one test is skipped (and this will then be fixed by letting the JSON code work column-by-column)

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Internals Related to non-user accessible pandas implementation IO JSON read_json, to_json, json_normalize labels Apr 21, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Apr 21, 2021
@jorisvandenbossche
Copy link
Member Author

The failure is a flaky ResourceWarning error

Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorisvandenbossche jorisvandenbossche merged commit 11545d5 into pandas-dev:master Apr 21, 2021
@jorisvandenbossche jorisvandenbossche deleted the am-io-json-tests branch April 21, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation IO JSON read_json, to_json, json_normalize Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants