Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyword sort to pivot_table #40954

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Add keyword sort to pivot_table #40954

merged 1 commit into from
Apr 20, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 14, 2021

This adds support for sort=False to pivot_table if we want to do this

@phofl phofl added Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Apr 14, 2021
attack68
attack68 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. im +1 for this.

@mroeschke mroeschke added this to the 1.3 milestone Apr 20, 2021
mroeschke
mroeschke approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems reasonable to me as well.

@jreback jreback merged commit 855696c into pandas-dev:master Apr 20, 2021
@jreback
Copy link
Contributor

jreback commented Apr 20, 2021

thanks @phofl very nice!

yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request Apr 21, 2021
@phofl @yeshsurya
Add keyword sort to pivot_table (pandas-dev#40954)
118afad
@jiahe224
Copy link

Will keyword sort be added to pivot?

@phofl
Copy link
Member Author

phofl commented Apr 21, 2021

see #15105

@phofl phofl deleted the 39143 branch April 21, 2021 20:40
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
@phofl @yeshsurya
Add keyword sort to pivot_table (pandas-dev#40954)
f0202bf
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@phofl @JulianWgs
Add keyword sort to pivot_table (pandas-dev#40954)
5db5ca7
@ShawnZhong ShawnZhong mentioned this pull request May 11, 2022
Merged
4 tasks
@hoesler hoesler mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@attack68 attack68 attack68 approved these changes

Assignees
No one assigned
Labels
Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

QST:Why DataFrame.pivot() will change the order of the rows of DataFrame?
5 participants
@phofl @jreback @jiahe224 @mroeschke @attack68