Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: use DeprecationWarning instead of FutureWarning for CategoricalBlock #40568

Merged

Conversation

jorisvandenbossche
Copy link
Member

Follow-up on #40527

There is no need for end-users to see this warning if an underlying library they use generates this, so using a DeprecationWarning instead of FutureWarning (as we did before with potentially noisy or internal warnings). At a later point we can change to FutureWarning.

@jorisvandenbossche jorisvandenbossche added Internals Related to non-user accessible pandas implementation Deprecate Functionality to remove in pandas labels Mar 22, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Mar 22, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for following up on this

@jbrockmendel jbrockmendel merged commit ced764d into pandas-dev:master Mar 22, 2021
@jbrockmendel
Copy link
Member

thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the depr-categoricalblock branch March 22, 2021 23:46
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants