[ArrayManager] Enable read_parquet to not create 2D blocks when using ArrayManager #40303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Apr 23, 2021
|
|
||
| # setup engines & skips | ||
| @pytest.fixture( | ||
| params=[ | ||
| pytest.param( | ||
| "fastparquet", | ||
| marks=pytest.mark.skipif( | ||
| not _HAVE_FASTPARQUET, reason="fastparquet is not installed" | ||
| not _HAVE_FASTPARQUET or get_option("mode.data_manager") == "array", | ||
| reason="fastparquet is not installed or ArrayManager is used", |
There was a problem hiding this comment.
is this a "for now" or a "ever"?
There was a problem hiding this comment.
If your question is about "will ArrayManager be supported with fastparquet engine", that's probably a question for the fastparquet package (and since this is only optional for now, there is still time to discuss that with them)
There was a problem hiding this comment.
ok, so not actionable on our end, thanks
|
small question, LGTM |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39146
I was exploring the Parquet IO, and pyarrow has an option to not created consolidated blocks. If we do this when wanting to create an ArrayManager, we can reduce the memory usage. It's a bit slower, though, because there is still the overhead of creating more blocks (that's something that would need to be changed in pyarrow).
Would still need to add a test that checks the option is honored.