Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArrayManager] TST: activate a bunch of (passing) tests #40217

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Mar 4, 2021

xref #39146

This is on top of #40152, so only the second commit is relevant: e7209aa

But this basically adds the following to CI for ArrayManager:

        pytest pandas/tests/api/ --array-manager
        pytest pandas/tests/base/ --array-manager
        pytest pandas/tests/computation/ --array-manager
        pytest pandas/tests/config/ --array-manager
        pytest pandas/tests/dtypes/ --array-manager
        pytest pandas/tests/generic/ --array-manager
        pytest pandas/tests/indexes/ --array-manager
        pytest pandas/tests/libs/ --array-manager
        pytest pandas/tests/plotting/ --array-manager
        pytest pandas/tests/scalar/ --array-manager
        pytest pandas/tests/strings/ --array-manager
        pytest pandas/tests/tools/ --array-manager
        pytest pandas/tests/tseries/ --array-manager
        pytest pandas/tests/tslibs/ --array-manager
        pytest pandas/tests/util/ --array-manager

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Internals Related to non-user accessible pandas implementation labels Mar 4, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Mar 4, 2021
@jbrockmendel
Copy link
Member

LGTM (just looked at the second commit)

for testing locally, is there a simple command i can use instead of copy/pasting the entire list of files?

@jorisvandenbossche
Copy link
Member Author

is there a simple command i can use instead of copy/pasting the entire list of files?

What do you mean exactly? To only run the tests that are already activated on CI?

@jbrockmendel
Copy link
Member

What do you mean exactly? To only run the tests that are already activated on CI?

yah, ATM when i want to run the relevant ArrayManager tests i do pytest pandas/tests/foo panda/test/bar pandas/tests/baz [...] --array-manager and its starting to involve a lot of copy/pasting (which is a good thing!)

@jreback
Copy link
Contributor

jreback commented Mar 5, 2021

can you rebase

@jorisvandenbossche jorisvandenbossche merged commit ee50197 into pandas-dev:master Mar 5, 2021
@jorisvandenbossche jorisvandenbossche deleted the am-more-tests branch March 5, 2021 08:30
@jorisvandenbossche
Copy link
Member Author

yah, ATM when i want to run the relevant ArrayManager tests i do pytest pandas/tests/foo panda/test/bar pandas/tests/baz [...] --array-manager and its starting to involve a lot of copy/pasting (which is a good thing!)

Yeah, that's a little bit annoying. Most of the time I am focusing on tests in a single directory, and then that's OK. But we're getting closer to get all tests running ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants